-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hootbin for tests #703
Conversation
d684585
to
814f69f
Compare
@jsha unless you have objections, I'd like to merge this. |
Alright. I'll merge this. We can always revert it. |
This change may need to be reverted - it looks like there's an issue in |
I'm running into this as well. It seems it only builds properly on 1.75, it's borked for me on anything at rust 1.74.1 and below wtih:
|
This change also breaks builds with any rustc older than 1.65, which is very unfortunate: #713 |
Thanks! I'm solving this now. |
Thanks for the quick reaction, and especially also for the introduction of a 1.61 MSRV. It's great to have that guarantee! However, I'm a bit dubious if doctests really warrant the introduction of |
I know. When I started that journey I didn't realise doc tests require non-dev deps. The reliance on httpbin.org for all things was not working anymore – making new ureq releases to address rustls, cookie etc version had just ground to a halt. The choice was between making hoot/hootbin a full dependency or starting from scratch with solving the impasse. I don't have the time for that now, and I figured it's more important to get other dependencies and fixes up-to-date. |
I also ended up here after seeing an unexpected extra dependency appear in Some ideas (apologies if you've already tried these and ruled them out):
|
Hi @edmorley, I don't mind having optional features for running the tests. I'll explore this weekend. |
Didn't work btw. :( |
I presume this was before you figured it out - I see #729 has now made |
Yeah. I found the solution minutes after I posted :) |
This is an attempt to address the problem with using httpbin.org in our tests.
hootbin
is a very rough approximation of httpbin built on the libraryhoot
.hoot
is a no_std experimental library where I am exploring how to implement a "correct" HTTP/1.1 client/server using Rust type state variables. I figured as a proof-of-concept I could use it to implement a simple server part for ureq's tests.If the hoot experiment works out, I might suggest using it to underpin a future ureq 3.0.
Close #688
The biggest drawback of this PR is that it introduces hoot as a main dependency, due to doc tests.